From 598ee2bd0abebf9b44f44789b2975bd7d1f319ea Mon Sep 17 00:00:00 2001
From: KuhnChris <kuhnchris@kuhnchris.eu>
Date: Sun, 12 Feb 2023 13:09:33 +0100
Subject: [PATCH] use pathlib; .exists() check

---
 tubesync/sync/views.py | 31 ++++++++++++++++++-------------
 1 file changed, 18 insertions(+), 13 deletions(-)

diff --git a/tubesync/sync/views.py b/tubesync/sync/views.py
index 6b5fcf1..f0c0bc5 100644
--- a/tubesync/sync/views.py
+++ b/tubesync/sync/views.py
@@ -1,8 +1,10 @@
 import os
 import json
 from base64 import b64decode
+import pathlib
+import sys
 from django.conf import settings
-from django.http import FileResponse, Http404
+from django.http import FileResponse, Http404, HttpResponseNotFound
 from django.views.generic import TemplateView, ListView, DetailView
 from django.views.generic.edit import (FormView, FormMixin, CreateView, UpdateView,
                                        DeleteView)
@@ -677,13 +679,8 @@ class MediaContent(DetailView):
 
     def dispatch(self, request, *args, **kwargs):
         self.object = self.get_object()
-        headers = {
-            'Content-Type': self.object.content_type,
-            'X-Accel-Redirect': self.object.media_file.url,
-        }
-
         # development direct file stream - DO NOT USE PRODUCTIVLY
-        if settings.PROVIDE_FILES_DIRECTLY:
+        if settings.DEBUG and 'runserver' in sys.argv:
             # get media URL
             pth = self.object.media_file.url
             # remove "/media-data/"
@@ -696,15 +693,23 @@ class MediaContent(DetailView):
                 pth = pth[1]
             else:
                 pth = pth[0]
-
+            
+            
             # build final path
-            filepth = str(settings.DOWNLOAD_ROOT) + "/" + pth
-
-            # return file
-            response = FileResponse(open(filepth,'rb'))
-            return response
+            filepth = pathlib.Path(str(settings.DOWNLOAD_ROOT) + pth)
+            
+            if filepth.exists():
+                # return file
+                response = FileResponse(open(filepth,'rb'))
+                return response
+            else:
+                return HttpResponseNotFound()
             
         else:
+            headers = {
+                'Content-Type': self.object.content_type,
+                'X-Accel-Redirect': self.object.media_file.url,
+            }
             return HttpResponse(headers=headers)