nthfuncx/nanoclaw
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

refactor: CI optimization, logging improvements, and codebase formatting (#456)

Browse Source 
* fix(db): remove unique constraint on folder to support multi-channel agents

* ci: implement automated skill drift detection and self-healing PRs

* fix: align registration logic with Gavriel's feedback and fix build/test issues from Daniel Mi

* style: conform to prettier standards for CI validation

* test: fix branch naming inconsistency in CI (master vs main)

* fix(ci): robust module resolution by removing file extensions in scripts

* refactor(ci): simplify skill validation by removing redundant combination tests

* style: conform skills-engine to prettier, unify logging in index.ts and cleanup unused imports

* refactor: extract multi-channel DB changes to separate branch

Move channel column, folder suffix logic, and related migrations
to feat/multi-channel-db-v2 for independent review. This PR now
contains only CI/CD optimizations, Prettier formatting, and
logging improvements.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Gabi Simons
2026-02-25 23:13:36 +02:00
committed by GitHub
parent bd2e236f73
commit 11c201088b
76 changed files with 2333 additions and 1308 deletions
Download Patch File Download Diff File Expand all files Collapse all files

88
skills-engine/__tests__/file-ops.test.ts
View File

@@ -9,11 +9,9 @@ function shouldSkipSymlinkTests(err: unknown): boolean {
err &&
typeof err === 'object' &&
'code' in err &&
(
(err as { code?: string }).code === 'EPERM' ||
((err as { code?: string }).code === 'EPERM' ||
(err as { code?: string }).code === 'EACCES' ||
(err as { code?: string }).code === 'ENOSYS'
)
(err as { code?: string }).code === 'ENOSYS')
);
}
@@ -33,9 +31,10 @@ describe('file-ops', () => {
it('rename success', () => {
fs.writeFileSync(path.join(tmpDir, 'old.ts'), 'content');
const result = executeFileOps([
{ type: 'rename', from: 'old.ts', to: 'new.ts' },
], tmpDir);
const result = executeFileOps(
[{ type: 'rename', from: 'old.ts', to: 'new.ts' }],
tmpDir,
);
expect(result.success).toBe(true);
expect(fs.existsSync(path.join(tmpDir, 'new.ts'))).toBe(true);
expect(fs.existsSync(path.join(tmpDir, 'old.ts'))).toBe(false);
@@ -43,9 +42,10 @@ describe('file-ops', () => {
it('move success', () => {
fs.writeFileSync(path.join(tmpDir, 'file.ts'), 'content');
const result = executeFileOps([
{ type: 'move', from: 'file.ts', to: 'sub/file.ts' },
], tmpDir);
const result = executeFileOps(
[{ type: 'move', from: 'file.ts', to: 'sub/file.ts' }],
tmpDir,
);
expect(result.success).toBe(true);
expect(fs.existsSync(path.join(tmpDir, 'sub', 'file.ts'))).toBe(true);
expect(fs.existsSync(path.join(tmpDir, 'file.ts'))).toBe(false);
@@ -53,9 +53,10 @@ describe('file-ops', () => {
it('delete success', () => {
fs.writeFileSync(path.join(tmpDir, 'remove-me.ts'), 'content');
const result = executeFileOps([
{ type: 'delete', path: 'remove-me.ts' },
], tmpDir);
const result = executeFileOps(
[{ type: 'delete', path: 'remove-me.ts' }],
tmpDir,
);
expect(result.success).toBe(true);
expect(fs.existsSync(path.join(tmpDir, 'remove-me.ts'))).toBe(false);
});
@@ -63,43 +64,50 @@ describe('file-ops', () => {
it('rename target exists produces error', () => {
fs.writeFileSync(path.join(tmpDir, 'a.ts'), 'a');
fs.writeFileSync(path.join(tmpDir, 'b.ts'), 'b');
const result = executeFileOps([
{ type: 'rename', from: 'a.ts', to: 'b.ts' },
], tmpDir);
const result = executeFileOps(
[{ type: 'rename', from: 'a.ts', to: 'b.ts' }],
tmpDir,
);
expect(result.success).toBe(false);
expect(result.errors.length).toBeGreaterThan(0);
});
it('delete missing file produces warning not error', () => {
const result = executeFileOps([
{ type: 'delete', path: 'nonexistent.ts' },
], tmpDir);
const result = executeFileOps(
[{ type: 'delete', path: 'nonexistent.ts' }],
tmpDir,
);
expect(result.success).toBe(true);
expect(result.warnings.length).toBeGreaterThan(0);
});
it('move creates destination directory', () => {
fs.writeFileSync(path.join(tmpDir, 'src.ts'), 'content');
const result = executeFileOps([
{ type: 'move', from: 'src.ts', to: 'deep/nested/dir/src.ts' },
], tmpDir);
const result = executeFileOps(
[{ type: 'move', from: 'src.ts', to: 'deep/nested/dir/src.ts' }],
tmpDir,
);
expect(result.success).toBe(true);
expect(fs.existsSync(path.join(tmpDir, 'deep', 'nested', 'dir', 'src.ts'))).toBe(true);
expect(
fs.existsSync(path.join(tmpDir, 'deep', 'nested', 'dir', 'src.ts')),
).toBe(true);
});
it('path escape produces error', () => {
fs.writeFileSync(path.join(tmpDir, 'file.ts'), 'content');
const result = executeFileOps([
{ type: 'rename', from: 'file.ts', to: '../../escaped.ts' },
], tmpDir);
const result = executeFileOps(
[{ type: 'rename', from: 'file.ts', to: '../../escaped.ts' }],
tmpDir,
);
expect(result.success).toBe(false);
expect(result.errors.length).toBeGreaterThan(0);
});
it('source missing produces error for rename', () => {
const result = executeFileOps([
{ type: 'rename', from: 'missing.ts', to: 'new.ts' },
], tmpDir);
const result = executeFileOps(
[{ type: 'rename', from: 'missing.ts', to: 'new.ts' }],
tmpDir,
);
expect(result.success).toBe(false);
expect(result.errors.length).toBeGreaterThan(0);
});
@@ -117,12 +125,15 @@ describe('file-ops', () => {
fs.writeFileSync(path.join(tmpDir, 'source.ts'), 'content');
const result = executeFileOps([
{ type: 'move', from: 'source.ts', to: 'linkdir/pwned.ts' },
], tmpDir);
const result = executeFileOps(
[{ type: 'move', from: 'source.ts', to: 'linkdir/pwned.ts' }],
tmpDir,
);
expect(result.success).toBe(false);
expect(result.errors.some((e) => e.includes('escapes project root'))).toBe(true);
expect(result.errors.some((e) => e.includes('escapes project root'))).toBe(
true,
);
expect(fs.existsSync(path.join(tmpDir, 'source.ts'))).toBe(true);
expect(fs.existsSync(path.join(outsideDir, 'pwned.ts'))).toBe(false);
@@ -142,12 +153,15 @@ describe('file-ops', () => {
throw err;
}
const result = executeFileOps([
{ type: 'delete', path: 'linkdir/victim.ts' },
], tmpDir);
const result = executeFileOps(
[{ type: 'delete', path: 'linkdir/victim.ts' }],
tmpDir,
);
expect(result.success).toBe(false);
expect(result.errors.some((e) => e.includes('escapes project root'))).toBe(true);
expect(result.errors.some((e) => e.includes('escapes project root'))).toBe(
true,
);
expect(fs.existsSync(outsideFile)).toBe(true);
cleanup(outsideDir);