* feat: per-group timezone architecture with context injection (#483) Implement a comprehensive timezone consistency layer so the AI agent always receives timestamps in the user's local timezone. The framework handles all UTC↔local conversion transparently — the agent never performs manual timezone math. Key changes: - Per-group timezone stored in containerConfig (no DB migration needed) - Context injection: <context timezone="..." current_time="..." /> header prepended to every agent prompt with local time and IANA timezone - Message timestamps converted from UTC to local display in formatMessages() - schedule_task translation layer: agent writes local times, framework converts to UTC using per-group timezone for cron, once, and interval types - Container TZ env var now uses per-group timezone instead of global constant - New set_timezone MCP tool for users to update their timezone dynamically - NANOCLAW_TIMEZONE passed to MCP server environment for tool confirmations Architecture: Store UTC everywhere, convert at boundaries (display to agent, parse from agent). Groups without timezone configured fall back to the server TIMEZONE constant for full backward compatibility. Closes #483 Closes #526 Co-authored-by: shawnYJ <shawny011717@users.noreply.github.com> Co-authored-by: Adrian <Lafunamor@users.noreply.github.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> * style: apply prettier formatting Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> * refactor: strip to minimalist context injection — global TIMEZONE only Remove per-group timezone support, set_timezone MCP tool, and all related IPC handlers. The implementation now uses the global system TIMEZONE for all groups, keeping the diff focused on the message formatting layer: mandatory timezone param in formatMessages(), <context> header injection, and formatLocalTime/formatCurrentTime helpers. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * refactor: drop formatCurrentTime and simplify context header Address PR review: remove redundant formatCurrentTime() since message timestamps already carry localized times. Simplify <context> header to only include timezone name. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: shawnYJ <shawny011717@users.noreply.github.com> Co-authored-by: Adrian <Lafunamor@users.noreply.github.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
257 lines
7.8 KiB
TypeScript
257 lines
7.8 KiB
TypeScript
import { describe, it, expect } from 'vitest';
|
|
|
|
import { ASSISTANT_NAME, TRIGGER_PATTERN } from './config.js';
|
|
import {
|
|
escapeXml,
|
|
formatMessages,
|
|
formatOutbound,
|
|
stripInternalTags,
|
|
} from './router.js';
|
|
import { NewMessage } from './types.js';
|
|
|
|
function makeMsg(overrides: Partial<NewMessage> = {}): NewMessage {
|
|
return {
|
|
id: '1',
|
|
chat_jid: 'group@g.us',
|
|
sender: '123@s.whatsapp.net',
|
|
sender_name: 'Alice',
|
|
content: 'hello',
|
|
timestamp: '2024-01-01T00:00:00.000Z',
|
|
...overrides,
|
|
};
|
|
}
|
|
|
|
// --- escapeXml ---
|
|
|
|
describe('escapeXml', () => {
|
|
it('escapes ampersands', () => {
|
|
expect(escapeXml('a & b')).toBe('a & b');
|
|
});
|
|
|
|
it('escapes less-than', () => {
|
|
expect(escapeXml('a < b')).toBe('a < b');
|
|
});
|
|
|
|
it('escapes greater-than', () => {
|
|
expect(escapeXml('a > b')).toBe('a > b');
|
|
});
|
|
|
|
it('escapes double quotes', () => {
|
|
expect(escapeXml('"hello"')).toBe('"hello"');
|
|
});
|
|
|
|
it('handles multiple special characters together', () => {
|
|
expect(escapeXml('a & b < c > d "e"')).toBe(
|
|
'a & b < c > d "e"',
|
|
);
|
|
});
|
|
|
|
it('passes through strings with no special chars', () => {
|
|
expect(escapeXml('hello world')).toBe('hello world');
|
|
});
|
|
|
|
it('handles empty string', () => {
|
|
expect(escapeXml('')).toBe('');
|
|
});
|
|
});
|
|
|
|
// --- formatMessages ---
|
|
|
|
describe('formatMessages', () => {
|
|
const TZ = 'UTC';
|
|
|
|
it('formats a single message as XML with context header', () => {
|
|
const result = formatMessages([makeMsg()], TZ);
|
|
expect(result).toContain('<context timezone="UTC" />');
|
|
expect(result).toContain('<message sender="Alice"');
|
|
expect(result).toContain('>hello</message>');
|
|
expect(result).toContain('Jan 1, 2024');
|
|
});
|
|
|
|
it('formats multiple messages', () => {
|
|
const msgs = [
|
|
makeMsg({
|
|
id: '1',
|
|
sender_name: 'Alice',
|
|
content: 'hi',
|
|
timestamp: '2024-01-01T00:00:00.000Z',
|
|
}),
|
|
makeMsg({
|
|
id: '2',
|
|
sender_name: 'Bob',
|
|
content: 'hey',
|
|
timestamp: '2024-01-01T01:00:00.000Z',
|
|
}),
|
|
];
|
|
const result = formatMessages(msgs, TZ);
|
|
expect(result).toContain('sender="Alice"');
|
|
expect(result).toContain('sender="Bob"');
|
|
expect(result).toContain('>hi</message>');
|
|
expect(result).toContain('>hey</message>');
|
|
});
|
|
|
|
it('escapes special characters in sender names', () => {
|
|
const result = formatMessages([makeMsg({ sender_name: 'A & B <Co>' })], TZ);
|
|
expect(result).toContain('sender="A & B <Co>"');
|
|
});
|
|
|
|
it('escapes special characters in content', () => {
|
|
const result = formatMessages(
|
|
[makeMsg({ content: '<script>alert("xss")</script>' })],
|
|
TZ,
|
|
);
|
|
expect(result).toContain(
|
|
'<script>alert("xss")</script>',
|
|
);
|
|
});
|
|
|
|
it('handles empty array', () => {
|
|
const result = formatMessages([], TZ);
|
|
expect(result).toContain('<context timezone="UTC" />');
|
|
expect(result).toContain('<messages>\n\n</messages>');
|
|
});
|
|
|
|
it('converts timestamps to local time for given timezone', () => {
|
|
// 2024-01-01T18:30:00Z in America/New_York (EST) = 1:30 PM
|
|
const result = formatMessages(
|
|
[makeMsg({ timestamp: '2024-01-01T18:30:00.000Z' })],
|
|
'America/New_York',
|
|
);
|
|
expect(result).toContain('1:30');
|
|
expect(result).toContain('PM');
|
|
expect(result).toContain('<context timezone="America/New_York" />');
|
|
});
|
|
});
|
|
|
|
// --- TRIGGER_PATTERN ---
|
|
|
|
describe('TRIGGER_PATTERN', () => {
|
|
const name = ASSISTANT_NAME;
|
|
const lower = name.toLowerCase();
|
|
const upper = name.toUpperCase();
|
|
|
|
it('matches @name at start of message', () => {
|
|
expect(TRIGGER_PATTERN.test(`@${name} hello`)).toBe(true);
|
|
});
|
|
|
|
it('matches case-insensitively', () => {
|
|
expect(TRIGGER_PATTERN.test(`@${lower} hello`)).toBe(true);
|
|
expect(TRIGGER_PATTERN.test(`@${upper} hello`)).toBe(true);
|
|
});
|
|
|
|
it('does not match when not at start of message', () => {
|
|
expect(TRIGGER_PATTERN.test(`hello @${name}`)).toBe(false);
|
|
});
|
|
|
|
it('does not match partial name like @NameExtra (word boundary)', () => {
|
|
expect(TRIGGER_PATTERN.test(`@${name}extra hello`)).toBe(false);
|
|
});
|
|
|
|
it('matches with word boundary before apostrophe', () => {
|
|
expect(TRIGGER_PATTERN.test(`@${name}'s thing`)).toBe(true);
|
|
});
|
|
|
|
it('matches @name alone (end of string is a word boundary)', () => {
|
|
expect(TRIGGER_PATTERN.test(`@${name}`)).toBe(true);
|
|
});
|
|
|
|
it('matches with leading whitespace after trim', () => {
|
|
// The actual usage trims before testing: TRIGGER_PATTERN.test(m.content.trim())
|
|
expect(TRIGGER_PATTERN.test(`@${name} hey`.trim())).toBe(true);
|
|
});
|
|
});
|
|
|
|
// --- Outbound formatting (internal tag stripping + prefix) ---
|
|
|
|
describe('stripInternalTags', () => {
|
|
it('strips single-line internal tags', () => {
|
|
expect(stripInternalTags('hello <internal>secret</internal> world')).toBe(
|
|
'hello world',
|
|
);
|
|
});
|
|
|
|
it('strips multi-line internal tags', () => {
|
|
expect(
|
|
stripInternalTags('hello <internal>\nsecret\nstuff\n</internal> world'),
|
|
).toBe('hello world');
|
|
});
|
|
|
|
it('strips multiple internal tag blocks', () => {
|
|
expect(
|
|
stripInternalTags('<internal>a</internal>hello<internal>b</internal>'),
|
|
).toBe('hello');
|
|
});
|
|
|
|
it('returns empty string when text is only internal tags', () => {
|
|
expect(stripInternalTags('<internal>only this</internal>')).toBe('');
|
|
});
|
|
});
|
|
|
|
describe('formatOutbound', () => {
|
|
it('returns text with internal tags stripped', () => {
|
|
expect(formatOutbound('hello world')).toBe('hello world');
|
|
});
|
|
|
|
it('returns empty string when all text is internal', () => {
|
|
expect(formatOutbound('<internal>hidden</internal>')).toBe('');
|
|
});
|
|
|
|
it('strips internal tags from remaining text', () => {
|
|
expect(
|
|
formatOutbound('<internal>thinking</internal>The answer is 42'),
|
|
).toBe('The answer is 42');
|
|
});
|
|
});
|
|
|
|
// --- Trigger gating with requiresTrigger flag ---
|
|
|
|
describe('trigger gating (requiresTrigger interaction)', () => {
|
|
// Replicates the exact logic from processGroupMessages and startMessageLoop:
|
|
// if (!isMainGroup && group.requiresTrigger !== false) { check trigger }
|
|
function shouldRequireTrigger(
|
|
isMainGroup: boolean,
|
|
requiresTrigger: boolean | undefined,
|
|
): boolean {
|
|
return !isMainGroup && requiresTrigger !== false;
|
|
}
|
|
|
|
function shouldProcess(
|
|
isMainGroup: boolean,
|
|
requiresTrigger: boolean | undefined,
|
|
messages: NewMessage[],
|
|
): boolean {
|
|
if (!shouldRequireTrigger(isMainGroup, requiresTrigger)) return true;
|
|
return messages.some((m) => TRIGGER_PATTERN.test(m.content.trim()));
|
|
}
|
|
|
|
it('main group always processes (no trigger needed)', () => {
|
|
const msgs = [makeMsg({ content: 'hello no trigger' })];
|
|
expect(shouldProcess(true, undefined, msgs)).toBe(true);
|
|
});
|
|
|
|
it('main group processes even with requiresTrigger=true', () => {
|
|
const msgs = [makeMsg({ content: 'hello no trigger' })];
|
|
expect(shouldProcess(true, true, msgs)).toBe(true);
|
|
});
|
|
|
|
it('non-main group with requiresTrigger=undefined requires trigger (defaults to true)', () => {
|
|
const msgs = [makeMsg({ content: 'hello no trigger' })];
|
|
expect(shouldProcess(false, undefined, msgs)).toBe(false);
|
|
});
|
|
|
|
it('non-main group with requiresTrigger=true requires trigger', () => {
|
|
const msgs = [makeMsg({ content: 'hello no trigger' })];
|
|
expect(shouldProcess(false, true, msgs)).toBe(false);
|
|
});
|
|
|
|
it('non-main group with requiresTrigger=true processes when trigger present', () => {
|
|
const msgs = [makeMsg({ content: `@${ASSISTANT_NAME} do something` })];
|
|
expect(shouldProcess(false, true, msgs)).toBe(true);
|
|
});
|
|
|
|
it('non-main group with requiresTrigger=false always processes (no trigger needed)', () => {
|
|
const msgs = [makeMsg({ content: 'hello no trigger' })];
|
|
expect(shouldProcess(false, false, msgs)).toBe(true);
|
|
});
|
|
});
|